Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter pagination #115

Merged
merged 6 commits into from
Aug 26, 2024
Merged

Fix filter pagination #115

merged 6 commits into from
Aug 26, 2024

Conversation

selankon
Copy link
Collaborator

@selankon selankon commented Aug 26, 2024

Fixes #113
Fixes #114

  • When a filter is set, on accounts list page or on a process list page, it resets set the page to the first page. This was done refactoring the RoutedPaginationProvider exposing a setPage function. This function accepts a queyParams attribute so we can set the page and queryParams at same time. Then a hook useRoutedPaginationQueryParams is created to wrap a function that set the query params and reset de pago to the firs one
  • Add not valid process id message on the process list page: if the process id is odd and not an hex string, it doesn't do the call and show a form error message
  • Fix verify old route: the old path route has the missing # causing the router to add a // after the url when accessing to verify/
  • Use query params for accounts list filter instead of using route params. This uses the routed paginator refactor

The route is the same and it causes an error where accessing to verify page because it shows `//` at the end of the path.

Add the `#` to be more accurate at redirection time
Copy link

github-actions bot commented Aug 26, 2024

@github-actions github-actions bot temporarily deployed to pull request August 26, 2024 10:07 Inactive
Copy link

github-actions bot commented Aug 26, 2024

@github-actions github-actions bot temporarily deployed to pull request August 26, 2024 10:07 Inactive
@selankon selankon marked this pull request as draft August 26, 2024 10:09
@github-actions github-actions bot temporarily deployed to pull request August 26, 2024 10:16 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 26, 2024 10:16 Inactive
@selankon selankon marked this pull request as ready for review August 26, 2024 10:18
@github-actions github-actions bot temporarily deployed to pull request August 26, 2024 10:45 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 26, 2024 10:45 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 26, 2024 10:47 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 26, 2024 10:47 Inactive
@elboletaire elboletaire merged commit d2a765c into main Aug 26, 2024
3 checks passed
@elboletaire elboletaire deleted the b/fix-filter-pagination branch August 26, 2024 15:30
@elboletaire elboletaire mentioned this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants