-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix filter pagination #115
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The route is the same and it causes an error where accessing to verify page because it shows `//` at the end of the path. Add the `#` to be more accurate at redirection time
selankon
force-pushed
the
b/fix-filter-pagination
branch
from
August 26, 2024 10:46
10e5659
to
06167aa
Compare
elboletaire
approved these changes
Aug 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113
Fixes #114
RoutedPaginationProvider
exposing asetPage
function. This function accepts aqueyParams
attribute so we can set the page and queryParams at same time. Then a hookuseRoutedPaginationQueryParams
is created to wrap a function that set the query params and reset de pago to the firs one#
causing the router to add a//
after the url when accessing toverify/