Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulk bugfix #106

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Bulk bugfix #106

merged 5 commits into from
Aug 22, 2024

Conversation

selankon
Copy link
Collaborator

@selankon selankon commented Aug 22, 2024 •
edited
Loading

Fixes #97

  • Fixes vote package is encrypted error when looking vote transaction
  • Fixes abnormal behavior when accessing to validator account detail and navigating through fees and transactions
  • Unify NoResultsError component

image

  • Improve invalid election card

image

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 22, 2024 •
edited
Loading

🚀 Deployed on https://66c74b0abd73943728e20c2b--vocdoni-explorer-stg.netlify.app

@github-actions github-actions bot temporarily deployed to pull request August 22, 2024 08:44 Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 22, 2024 •
edited
Loading

🚀 Deployed on https://66c74b0bd1cee3370915323b--vocdoni-explorer-dev.netlify.app

@github-actions github-actions bot temporarily deployed to pull request August 22, 2024 08:44 Inactive
@selankon selankon changed the title Improve invalid election card Bulk bufix Aug 22, 2024
@selankon selankon marked this pull request as draft August 22, 2024 09:12
@selankon selankon force-pushed the f/improve-invalid-election-card branch from 5390fa9 to 3e578a6 Compare August 22, 2024 09:23
@selankon selankon marked this pull request as ready for review August 22, 2024 09:38
@selankon selankon force-pushed the f/improve-invalid-election-card branch from 3e578a6 to d3f7dfb Compare August 22, 2024 09:39
@github-actions github-actions bot temporarily deployed to pull request August 22, 2024 09:40 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 22, 2024 09:40 Inactive
@selankon selankon changed the title Bulk bufix Bulk bugfix Aug 22, 2024
elboletaire
elboletaire requested changes Aug 22, 2024
View reviewed changes
src/components/Accounts/Detail.tsx Outdated Show resolved Hide resolved
src/components/Layout/ContentError.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request August 22, 2024 14:28 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 22, 2024 14:28 Inactive
@elboletaire elboletaire merged commit 78f4b17 into main Aug 22, 2024
3 checks passed
@elboletaire elboletaire deleted the f/improve-invalid-election-card branch August 22, 2024 14:33
@elboletaire elboletaire mentioned this pull request Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elboletaire elboletaire elboletaire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the invalid election card in lists
2 participants
@selankon @elboletaire