-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to Go 1.10 #8304
base: master
Are you sure you want to change the base?
Move to Go 1.10 #8304
Conversation
CI looks still broken? |
CI won't run until I push an updated integration testing docker image (v1.49) with the changes in this PR. However, I don't want to push a new version of the image to the production registry until someone has done at least some basic review of the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This upgrade seems to change how SSL certificates are validated. Specifying a thumbprint is no longer sufficient to overcome certificate validation issues, such as those related to the use of self-signed certificates without IP SANs (resulting in error messages like This is especially problematic for commands like This is likely related to this note in the 1.10 release notes: https://golang.org/doc/go1.10#crypto/x509 |
Use Go 1.10 to compile the product. Update build image and Makefile accordingly. Fix unit tests which broke as a result of the upgrade.
Additionally, update dependencies so that build image can be built and clean up some modified tests.
Contains portions of #7610.
Fixes: #7609
[full ci]