Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Go 1.10 #8304

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Move to Go 1.10 #8304

wants to merge 11 commits into from

Conversation

zjs
Copy link
Member

@zjs zjs commented Sep 26, 2018

Use Go 1.10 to compile the product. Update build image and Makefile accordingly. Fix unit tests which broke as a result of the upgrade.

Additionally, update dependencies so that build image can be built and clean up some modified tests.


Contains portions of #7610.

Fixes: #7609

[full ci]

@zjs zjs self-assigned this Sep 26, 2018
@zjs zjs requested review from wjun, hickeng and a team September 26, 2018 00:50
@wjun
Copy link
Contributor

wjun commented Sep 27, 2018

CI looks still broken?

@zjs
Copy link
Member Author

zjs commented Sep 27, 2018

CI looks still broken?

CI won't run until I push an updated integration testing docker image (v1.49) with the changes in this PR. However, I don't want to push a new version of the image to the production registry until someone has done at least some basic review of the changes.

Copy link
Contributor

@wjun wjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zjs
Copy link
Member Author

zjs commented Oct 17, 2018

This upgrade seems to change how SSL certificates are validated. Specifying a thumbprint is no longer sufficient to overcome certificate validation issues, such as those related to the use of self-signed certificates without IP SANs (resulting in error messages like Post https://10.192.207.166/sdk: x509: cannot validate certificate for 10.192.207.166 because it doesn't contain any IP SANs).

This is especially problematic for commands like vic-machine ls, which support --thumbprint, but not --force.

This is likely related to this note in the 1.10 release notes: https://golang.org/doc/go1.10#crypto/x509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants