refactor --setopts handling #464
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverkurth
force-pushed
the
topic/okurth/refactor-setopts
branch
4 times, most recently
from
36c6c5c to
90f52ac
Compare
oliverkurth
force-pushed
the
topic/okurth/refactor-setopts
branch
from
90f52ac to
ef02abe
Compare
oliverkurth
force-pushed
the
topic/okurth/refactor-setopts
branch
from
ef02abe to
0d46923
Compare
This was referenced Sep 11, 2024
oliverkurth
force-pushed
the
topic/okurth/refactor-setopts
branch
from
0d46923 to
2f20038
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft, not yet ready to submit.
This refactors the implementation of
--setopt=for parity with dnf: any setting with--setoptshould override config settings, or in the case of lists (likebaseurl) append to them. With the patterns--setopt=<repo>.foo=a setting in the repo config will be reset.This also adds support for all rpm transaction flags, and support for setting them in the config file.
TODO:
TDNFHasOpt()inclient/plugins.cAddSetOptWithValuesintools/cli/lib/parseargs.c