🐛 Remove CL Item ContentVersion short circuit #852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid repeated CL Item sync tasks, we'll compare the item and image cached content versions, and skip fetching the OVF envelope if they match. But since we've added fields to the image Status (like Disks[]) in v1a3, those new fields won't be updated until the item changes. The big hammer for this is to just remove the check instead of including another internal version in the cached version. Short term, this will cause an increase in the number of sync tasks, but the existing OVF cache will reduce that somewhat. There is a larger WIP in this area that will fix this bug without the increase in sync tasks.
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
To avoid repeated CL Item sync tasks, we'll compare the item and image cached content versions, and skip fetching the OVF envelope if they match. But since we've added fields to the image Status (like Disks[]) in v1a3, those new fields won't be updated until the item changes.
The big hammer for this is to just remove the check instead of including another internal version in the cached version. Short term, this will cause an increase in the number of sync tasks, but the existing OVF cache will reduce that somewhat. There is a larger WIP in this area that will fix this bug without the increase in sync tasks.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
If the WIP takes longer to land than expected we can revise this by like appending "-v1a3" to our versions.
Please add a release note if necessary:
This is just a temp, quick fix.