Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Remove the v1a2 Network top-level interface-related fields #259

Merged
merged 1 commit into from
Nov 3, 2023
Merged

✨ Remove the v1a2 Network top-level interface-related fields #259

merged 1 commit into from
Nov 3, 2023

Conversation

bryanv
Copy link
Contributor

@bryanv bryanv commented Oct 26, 2023

Network interfaces now can only be specified via the Interfaces list, instead of duplicating several fields between the Spec.Network and the Spec.Network.Interfaces.

Similar to v1a1, use the mutation webhook to create a default interface when networking is not disabled.

NONE

@github-actions github-actions bot added testing-needed-e2e-fast size/XL Denotes a PR that changes 500-999 lines. labels Oct 26, 2023
srm09
srm09 reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@srm09 srm09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, otherwise LGTM

webhooks/virtualmachine/v1alpha2/mutation/virtualmachine_mutator.go Show resolved Hide resolved
webhooks/virtualmachine/v1alpha2/mutation/virtualmachine_mutator.go Show resolved Hide resolved
webhooks/virtualmachine/v1alpha2/mutation/virtualmachine_mutator_unit_test.go Outdated Show resolved Hide resolved
webhooks/virtualmachine/v1alpha2/mutation/virtualmachine_mutator_unit_test.go Show resolved Hide resolved
webhooks/virtualmachine/v1alpha2/mutation/virtualmachine_mutator_unit_test.go Outdated Show resolved Hide resolved
webhooks/virtualmachine/v1alpha2/validation/virtualmachine_validator_unit_test.go Outdated Show resolved Hide resolved
@bryanv bryanv force-pushed the bryanv/v1a2-network-spec-cleanup branch from 3e20540 to 05307ba Compare November 2, 2023 15:33
@bryanv
Remove the v1a2 Network top-level interface-related fields
ee02508 
Network interfaces now can only be specified via the Interfaces list,
instead of duplicating several fields between the Spec.Network and
the Spec.Network.Interfaces.

Similar to v1a1, use the mutation webhook to create a default interface
when networking is not disabled.
@bryanv bryanv force-pushed the bryanv/v1a2-network-spec-cleanup branch from 05307ba to ee02508 Compare November 3, 2023 21:23
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Code Coverage

Package Line Rate Health
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/v1alpha1/clustercontentlibraryitem 83% ✔
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/v1alpha1/contentlibraryitem 82% ✔
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/v1alpha1/contentsource 88% ✔
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/v1alpha1/utils 95% ✔
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/v1alpha2/clustercontentlibraryitem 86% ✔
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/v1alpha2/contentlibraryitem 85% ✔
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/v1alpha2/utils 91% ✔
github.com/vmware-tanzu/vm-operator/controllers/infracluster 75% ➖
github.com/vmware-tanzu/vm-operator/controllers/infraprovider 75% ➖
github.com/vmware-tanzu/vm-operator/controllers/providerconfigmap 75% ➖
github.com/vmware-tanzu/vm-operator/controllers/util/encoding 73% ➖
github.com/vmware-tanzu/vm-operator/controllers/util/remote 41% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/v1alpha1 46% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/v1alpha2 70% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineclass/v1alpha1 31% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineclass/v1alpha2 71% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinepublishrequest/v1alpha1 83% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinepublishrequest/v1alpha2 81% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/v1alpha1 81% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/v1alpha1/providers 96% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/v1alpha1/providers/simplelb 66% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/v1alpha1/utils 83% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/v1alpha2 82% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/v1alpha2/providers 96% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/v1alpha2/providers/simplelb 66% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/v1alpha2/utils 85% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinesetresourcepolicy/v1alpha1 80% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinesetresourcepolicy/v1alpha2 80% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1 74% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha2 72% ➖
github.com/vmware-tanzu/vm-operator/controllers/volume/v1alpha1 87% ✔
github.com/vmware-tanzu/vm-operator/controllers/volume/v1alpha2 86% ✔
github.com/vmware-tanzu/vm-operator/pkg/builder 73% ➖
github.com/vmware-tanzu/vm-operator/pkg/conditions 90% ✔
github.com/vmware-tanzu/vm-operator/pkg/conditions2 90% ✔
github.com/vmware-tanzu/vm-operator/pkg/context 0% ❌
github.com/vmware-tanzu/vm-operator/pkg/context/fake 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/lib 87% ✔
github.com/vmware-tanzu/vm-operator/pkg/manager 78% ➖
github.com/vmware-tanzu/vm-operator/pkg/metrics 90% ✔
github.com/vmware-tanzu/vm-operator/pkg/metrics2 85% ✔
github.com/vmware-tanzu/vm-operator/pkg/patch 79% ➖
github.com/vmware-tanzu/vm-operator/pkg/patch2 78% ➖
github.com/vmware-tanzu/vm-operator/pkg/prober 92% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober/context 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober/fake 85% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober/fake/probe 83% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober/fake/worker 88% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober/probe 83% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober/worker 86% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober2 94% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober2/context 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober2/fake 85% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober2/fake/probe 83% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober2/fake/worker 89% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober2/probe 89% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober2/worker 85% ✔
github.com/vmware-tanzu/vm-operator/pkg/record 89% ✔
github.com/vmware-tanzu/vm-operator/pkg/topology 85% ✔
github.com/vmware-tanzu/vm-operator/pkg/util 84% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/kube 89% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/vm 74% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/fake 76% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere 71% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/client 74% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/clustermodules 85% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/config 85% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/contentlibrary 71% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/credentials 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/instancestorage 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/internal 0% ❌
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/network 88% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/placement 83% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/resources 47% ❌
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/session 84% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/storage 77% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/test 98% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/vcenter 80% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/virtualmachine 83% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2 70% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/client 49% ❌
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/clustermodules 85% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/config 70% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/contentlibrary 50% ❌
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/credentials 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/instancestorage 75% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/internal 0% ❌
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/network 81% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/placement 70% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/resources 38% ❌
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/session 83% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/storage 77% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/test 98% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/vcenter 80% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/virtualmachine 83% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/vmlifecycle 78% ➖
github.com/vmware-tanzu/vm-operator/pkg/webconsolevalidation 53% ❌
github.com/vmware-tanzu/vm-operator/webhooks/common 100% ✔
github.com/vmware-tanzu/vm-operator/webhooks/persistentvolumeclaim/validation 95% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/v1alpha1/mutation 81% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/v1alpha1/validation 94% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/v1alpha2/mutation 79% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/v1alpha2/validation 95% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/v1alpha1/mutation 59% ❌
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/v1alpha1/validation 89% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/v1alpha2/mutation 59% ❌
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/v1alpha2/validation 89% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinepublishrequest/v1alpha1/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinepublishrequest/v1alpha2/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/v1alpha1/mutation 62% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/v1alpha1/validation 91% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/v1alpha2/mutation 62% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/v1alpha2/validation 91% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinesetresourcepolicy/v1alpha1/mutation 62% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinesetresourcepolicy/v1alpha1/validation 89% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinesetresourcepolicy/v1alpha2/validation 89% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/v1alpha1/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/v1alpha2/validation 92% ✔
Summary 79% (11678 / 14712) ➖

Minimum allowed line rate is 60%

@bryanv bryanv added the testing-done-e2e-fast Indicates the fast, low-cost e2e testing has been used to validate a PR label Nov 3, 2023
@bryanv bryanv merged commit 20a1078 into vmware-tanzu:main Nov 3, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srm09 srm09 srm09 approved these changes

Assignees
No one assigned
Labels
cla-not-required size/XL Denotes a PR that changes 500-999 lines. testing-done-e2e-fast Indicates the fast, low-cost e2e testing has been used to validate a PR testing-needed-e2e-fast
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryanv @srm09 @vmwclabot