✨ Synthesize v1a1 Prereq condition from v1a2 conditions #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dilyar85
reviewed
Oct 17, 2023
zyiyi11
approved these changes
Oct 18, 2023
sreyasn
reviewed
Oct 19, 2023
bryanv
force-pushed
the
bryanv/better-v1a1-condition-conversion
branch
from
bf08fa9 to
2681a71
Compare
There is various weirdness around how and what we set the v1a1 Prereq condition to, so this isn't quite a complete match but hopefully good enough. For now just leave the conditions as-is when going from v1a1 to v1a2. We might later want to remove the Prereq - or other v1a1 only conditions - during that conversion.
bryanv
force-pushed
the
bryanv/better-v1a1-condition-conversion
branch
from
2681a71 to
aee0074
Compare
The straight type conversion is already there. Unless something breaks I don't intend to do anything v1a1 -> v1a2: v1a1 doesn't have the required info, and we'll let the VM reconcile populate what conditions it can. |
bryanv
added
the
testing-done-e2e-fast
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is various weirdness around how and what we set the v1a1 Prereq condition to, so this isn't quite a complete match but hopefully good enough.
For now just leave the conditions as-is when going from v1a1 to v1a2. We might later want to remove the Prereq - or other v1a1 only conditions - during that conversion.