🌱 Add VM backup implementation for v1a2 #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing-needed-e2e-fast
size/XL
dilyar85
force-pushed
the
feature/vm-backup-v1a2
branch
from
12a9c52 to
80c5ee3
Compare
dilyar85
added
the
testing-done-e2e-fast
bryanv
approved these changes
Oct 13, 2023
| BackupVMKubeDataExtraConfigKey = "vmservice.virtualmachine.kubedata" | ||
| // BackupVMBootstrapDataExtraConfigKey is the ExtraConfig key to the VM's | ||
| // bootstrap data object, compressed using gzip and base64-encoded. | ||
| BackupVMBootstrapDataExtraConfigKey = "vmservice.virtualmachine.bootstrapdata" |
There was a problem hiding this comment.
For v1a2 vApp customization there is also be a map of maps: see GetVirtualMachineBootstrap(). I'm pretty sure - once we get around to supporting it - the inlined CloudInit customization can also specify a map of maps.
I'm fine if we just what to worry about this case later.
There was a problem hiding this comment.
Yes, I have also left a todo comment to address this case. I will work on it once the v1a2 customization is ready (thought it would be easier to validate my change then).
dilyar85
force-pushed
the
feature/vm-backup-v1a2
branch
from
80c5ee3 to
91d5565
Compare
dilyar85
force-pushed
the
feature/vm-backup-v1a2
branch
from
91d5565 to
96894f9
Compare
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This patch adds the implementation code for VM backup in v1a2. It includes all the follow-up changes in #239 with some minor updates specific to v1a2.
Please add a release note if necessary: