UX: Add emojis #146
Closed
UX: Add emojis #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandrareddyp
force-pushed
the
change/ux-add-emojis
branch
from
bb3b311 to
eecd068
Compare
marckhouzam
reviewed
Jan 16, 2024
There was a problem hiding this comment.
This seems like a good idea to me but I'd like others to weigh in.
cc @anujc25 @vuil @mpanchajanya @prkalle
| @@ -0,0 +1,25 @@ | |||
| // Copyright 2022 VMware, Inc. All Rights Reserved. | |||
I like the idea too. I think we should also provide an option to disable emojis/colors if users choose to. |
|
UX design has changed, hence closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This pull request adds a list of emojis and an API to append a given emoji to text. This change helps highlight the UX by prefixing an emoji to UX logs.
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Tested in local, here is the output:
Release note
Additional information
Special notes for your reviewer