Update feature flags apis #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpanchajanya
force-pushed
the
update_features_apis
branch
3 times, most recently
from
d8dee28 to
50ea7f1
Compare
anujc25
reviewed
Jan 4, 2024
mpanchajanya
force-pushed
the
update_features_apis
branch
from
50ea7f1 to
fa5fa0b
Compare
mpanchajanya
force-pushed
the
update_features_apis
branch
from
fa5fa0b to
38f4900
Compare
marckhouzam
reviewed
Jan 9, 2024
| @@ -10,19 +10,23 @@ import ( | |||
| var ( | |||
| // legacyLocalDirName is the name of the old local directory in which to look for tanzu state. This will be | |||
| // removed in the future in favor of LocalDirName. | |||
| // Deprecated: This legacyLocalDirName is deprecated. Use next get config apis | |||
There was a problem hiding this comment.
All the new deprecations in this file are on private functions. Is there a reason we can’t just remove them?
There was a problem hiding this comment.
We already have our legacy store marked for deprecation I have just added these related private methods as well to be consistent. We would remove these when we remove the legacy store after the deprecation window.
| } | ||
|
|
||
| // IsFeatureFlagExists returns true if the features section in the configuration object contains any value for the plugin.feature combination | ||
| func (c *ClientConfig) IsFeatureFlagExists(plugin, feature string) bool { |
There was a problem hiding this comment.
That function name doesn’t sound good in English. How about just FeatureFlagExists? Or IsFeatureFlagSet?
There was a problem hiding this comment.
Updated the method name
mpanchajanya
force-pushed
the
update_features_apis
branch
from
38f4900 to
e54184b
Compare
vuil
pushed a commit
to vuil/tanzu-plugin-runtime
that referenced
this pull request
Jan 22, 2024
vuil
pushed a commit
that referenced
this pull request
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
- GetAllFeatureFlags
- ConfigureDefaultFeatureFlags
- IsConfigFeatureActivated
- IsFeatureFlagExists
- GetAllFeatureFlags
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer