Provide a 'LastRefresh' field for OCI discoveries #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used by the CLI to only refresh the plugin inventory DB at a certain interval, to make the plugin-lifecycle commands more responsive. Signed-off-by: Marc Khouzam <[email protected]>
vuil
reviewed
Dec 8, 2023
| @@ -234,6 +234,8 @@ type OCIDiscovery struct { | |||
| // Contains a directory containing YAML files, each of which contains single | |||
| // CLIPlugin API resource. | |||
| Image string `json:"image,omitempty" yaml:"image,omitempty"` | |||
| // LastRefresh allows to store the last time the OCI image was refreshed by the CLI | |||
| LastRefresh string `json:"lastrefresh,omitempty" yaml:"lastrefresh,omitempty"` | |||
There was a problem hiding this comment.
Wondering if this information
- needs to be part of the OCI configuration in the config file.
- we need a timestamp per OCI discovery source
It feels like something that only the core CLI need to track during it use and the information can be stored somewhere else.
(Setting aside vmware-tanzu/tanzu-cli#605 (comment) for the moment)
Could storing even a single timestamp in ~/.cache/tanzu/plugin_inventory have done the job as well?
|
After discussing this comment with @vuil, this PR will most probably not needed. I will mark it as draft until I have updated vmware-tanzu/tanzu-cli#605 and confirmed this can be closed. |
|
The PR that originally needed this change was reworked and simplified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This is meant to be used by the CLI to only refresh the plugin inventory DB at a certain interval, to make the plugin-lifecycle commands more responsive.
I included this field in an OCI discovery so that when we support more than once discovery, we are prepared.
Which issue(s) this PR fixes
Fixes # N/A
Describe testing done for PR
Let CI run.
The rest of the testing is done through the tanzu-cli PR that will use this new field.
I will update this PR with the other PR once it is opened.
Release note
Additional information
Special notes for your reviewer