Fix a bug in ACT_main json patch for Azure Cluster Class #4622
Conversation
Fix a go template bug which makes invalid the template rendering for the AzureClusterTemplate to inject mulitple VNET cidrs. Here is the capi-controller error log message without this fix: E0525 14:28:24.579774 1 controller.go:326] "Reconciler error" err="error reconciling the Cluster topology: failed to create AzureCluster.infrastructure.cluster.x-k8s.io: FieldValueInvalid: spec.networkSpec.cidrBlocks: Invalid value: \"10.221.98.192/27- 10.221.98.224/27\": invalid CIDR format FieldValueInvalid: spec.networkSpec.subnets[0].cidrBlocks: Invalid value: \"10.221.98.192/27\": subnet CIDR not in vnet address space: [10.221.98.192/27- 10.221.98.224/27] FieldValueInvalid: spec.networkSpec.subnets[1].cidrBlocks: Invalid value: \"10.221.98.224/27\": subnet CIDR not in vnet address space: [10.221.98.192/27- 10.221.98.224/27]" controller="topology/cluster" controllerGroup="cluster.x-k8s.io" controllerKind="Cluster" cluster="k8s-mma/k8s-mma" namespace="k8s-mma" name="k8s-mma" reconcileID=eea64084-273f-4028-9b70-374514886761
|
@PierrePIRONIN, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
|
Hi @PierrePIRONIN! And thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Tanzu Framework better. |
|
@PierrePIRONIN, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
|
@PierrePIRONIN, VMware has approved your signed contributor license agreement. |
|
@DanielXiao - can you take a look ? |
| @@ -759,7 +759,7 @@ spec: | |||
| name: {{ if .network.vnet.name }} {{- .network.vnet.name }} {{- else }} {{- .builtin.cluster.name -}} -vnet {{- end }} | |||
| resourceGroup: {{ if .network.vnet.resourceGroup }} {{- .network.vnet.resourceGroup }} {{- else if .resourceGroup }} {{- .resourceGroup }} {{- else }} {{- .builtin.cluster.name }} {{- end }} | |||
| cidrBlocks: | |||
There was a problem hiding this comment.
It seems there will be an empty line, we usually write iteration like this
cidrBlocks:
{{- range .network.vnet.cidrBlocks }}
- {{ . }}
{{- end }}
Fix a go template bug which makes invalid the template rendering for the AzureClusterTemplate to inject mulitple VNET cidrs.
What this PR does / why we need it
Fix a bug which blocks build of Azure Kubernetes cluster with multiple VNET cidrs (see related issue for more details).
Which issue(s) this PR fixes
Fixes #4621
Describe testing done for PR
Created Azure workload cluster to verify change and it works.
Release note
Additional information
Special notes for your reviewer
I’ve worked on it jointly with Pablo Iglesias (VMware Customer 0 team member)