Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: libpython and targets for python docker images #128

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix: libpython and targets for python docker images #128

merged 1 commit into from
Dec 11, 2023

Conversation

assambar
Copy link
Contributor

Add the static hashlib module to the bundled libpython. Without this using libpython will fail with undefined symbols.

Angelmmiguel
Angelmmiguel approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@Angelmmiguel Angelmmiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👏

@assambar assambar merged commit 040d5a6 into main Dec 11, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Angelmmiguel Angelmmiguel Angelmmiguel approved these changes

@ereslibre ereslibre Awaiting requested review from ereslibre

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@assambar @Angelmmiguel @vmwclabot