Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datagrid): exclude row checkbox from error styling and validation #1643

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dtsanevmw
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

If there is a datagrid under an element with 'clr-error' class the selection checkboxes receive the error styling.

Issue Number: CDE-2498

What is the new behavior?

No longer receiving error styling.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@dtsanevmw dtsanevmw requested a review from a team December 12, 2024 00:51
@dtsanevmw dtsanevmw self-assigned this Dec 12, 2024
Copy link
Contributor

github-actions bot commented Dec 12, 2024

👋 @dtsanevmw,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@dtsanevmw dtsanevmw force-pushed the dtsanevmw/datagrid-checkbox-cde-2498 branch from 7fa102a to a2e62a2 Compare December 12, 2024 12:26
@dtsanevmw dtsanevmw changed the title fix(datagrid): exclude selection checkbox from error styling fix(datagrid): exclude selection checkbox from error styling and validation Dec 12, 2024
@dtsanevmw dtsanevmw changed the title fix(datagrid): exclude selection checkbox from error styling and validation fix(datagrid): exclude select checkbox from error styling and validation Dec 12, 2024
@dtsanevmw dtsanevmw changed the title fix(datagrid): exclude select checkbox from error styling and validation fix(datagrid): exclude row checkbox from error styling and validation Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants