Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker): add support for confirmation action buttons #1639

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

venkateshr06
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: CDE-2497

What is the new behavior?

Confirmation action buttons (apply & cancel buttons) will be shown based on feature flag.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

github-actions bot commented Dec 9, 2024

👋 @kevinbuhmann,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@venkateshr06 venkateshr06 changed the title feat(datepicker): datepicker with action buttons feat(datepicker): picker with action buttons Dec 9, 2024
@venkateshr06 venkateshr06 changed the title feat(datepicker): picker with action buttons feat(datepicker): add support for confirmation action buttons Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

This PR introduces visual changes: c7e5809
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout venkat/datepicker-with-action-buttons
git fetch https://github.com/vmware-clarity/ng-clarity.git c7e5809b2127b672249f5a4c6aee91ff66a0df4a
git cherry-pick c7e5809b2127b672249f5a4c6aee91ff66a0df4a
git push

@venkateshr06 venkateshr06 self-assigned this Dec 9, 2024
Co-authored-by: Kevin Buhmann <[email protected]>
Copy link
Contributor

github-actions bot commented Jan 9, 2025

This PR introduces visual changes: 34e3d2c
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout venkat/datepicker-with-action-buttons
git fetch https://github.com/vmware-clarity/ng-clarity.git 34e3d2c1fac0d3e676c958bb68bc395bdf51e4ce
git cherry-pick 34e3d2c1fac0d3e676c958bb68bc395bdf51e4ce
git push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants