-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datepicker): add support for confirmation action buttons #1639
Open
venkateshr06
wants to merge
10
commits into
main
Choose a base branch
from
venkat/datepicker-with-action-buttons
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you, 🤖 Clarity Release Bot |
venkateshr06
changed the title
feat(datepicker): datepicker with action buttons
feat(datepicker): picker with action buttons
Dec 9, 2024
venkateshr06
changed the title
feat(datepicker): picker with action buttons
feat(datepicker): add support for confirmation action buttons
Dec 9, 2024
This PR introduces visual changes: c7e5809
|
dtsanevmw
reviewed
Dec 10, 2024
dtsanevmw
reviewed
Dec 10, 2024
dtsanevmw
reviewed
Dec 10, 2024
dtsanevmw
reviewed
Dec 10, 2024
dtsanevmw
reviewed
Dec 10, 2024
dtsanevmw
reviewed
Dec 10, 2024
dtsanevmw
reviewed
Dec 10, 2024
dtsanevmw
reviewed
Dec 10, 2024
projects/angular/src/forms/datepicker/_properties.datepicker.scss
Outdated
Show resolved
Hide resolved
dtsanevmw
reviewed
Dec 10, 2024
dtsanevmw
reviewed
Dec 10, 2024
projects/angular/src/forms/datepicker/_variables.datepicker.scss
Outdated
Show resolved
Hide resolved
dtsanevmw
reviewed
Dec 10, 2024
projects/angular/src/forms/datepicker/_variables.datepicker.scss
Outdated
Show resolved
Hide resolved
dtsanevmw
reviewed
Dec 10, 2024
projects/angular/src/forms/datepicker/datepicker-action-buttons.ts
Outdated
Show resolved
Hide resolved
dtsanevmw
reviewed
Dec 10, 2024
projects/angular/src/forms/datepicker/datepicker-action-buttons.ts
Outdated
Show resolved
Hide resolved
dtsanevmw
reviewed
Dec 10, 2024
projects/angular/src/forms/datepicker/datepicker-action-buttons.ts
Outdated
Show resolved
Hide resolved
dtsanevmw
reviewed
Dec 10, 2024
projects/angular/src/forms/datepicker/datepicker-view-manager.ts
Outdated
Show resolved
Hide resolved
kevinbuhmann
requested changes
Jan 9, 2025
projects/angular/src/forms/datepicker/providers/date-navigation.service.ts
Outdated
Show resolved
Hide resolved
projects/angular/src/forms/datepicker/providers/datepicker-helper.service.ts
Outdated
Show resolved
Hide resolved
projects/angular/src/forms/datepicker/providers/datepicker-helper.service.ts
Outdated
Show resolved
Hide resolved
projects/demo/src/app/datepicker/datepicker-with-action-buttons.ts
Outdated
Show resolved
Hide resolved
projects/demo/src/app/datepicker/datepicker-with-action-buttons.html
Outdated
Show resolved
Hide resolved
projects/demo/src/app/datepicker/datepicker-with-action-buttons.ts
Outdated
Show resolved
Hide resolved
projects/angular/src/forms/datepicker/providers/date-navigation.service.ts
Outdated
Show resolved
Hide resolved
projects/angular/src/forms/datepicker/providers/date-navigation.service.ts
Outdated
Show resolved
Hide resolved
projects/angular/src/forms/datepicker/providers/datepicker-helper.service.ts
Outdated
Show resolved
Hide resolved
kevinbuhmann
reviewed
Jan 9, 2025
projects/angular/src/forms/datepicker/providers/datepicker-helper.service.ts
Outdated
Show resolved
Hide resolved
kevinbuhmann
reviewed
Jan 9, 2025
kevinbuhmann
reviewed
Jan 9, 2025
kevinbuhmann
reviewed
Jan 9, 2025
projects/angular/src/forms/datepicker/datepicker-action-buttons.ts
Outdated
Show resolved
Hide resolved
kevinbuhmann
reviewed
Jan 9, 2025
projects/angular/src/forms/datepicker/datepicker-action-buttons.ts
Outdated
Show resolved
Hide resolved
kevinbuhmann
reviewed
Jan 9, 2025
projects/angular/src/forms/datepicker/datepicker-action-buttons.ts
Outdated
Show resolved
Hide resolved
kevinbuhmann
reviewed
Jan 9, 2025
projects/angular/src/forms/datepicker/datepicker-action-buttons.ts
Outdated
Show resolved
Hide resolved
kevinbuhmann
reviewed
Jan 9, 2025
projects/angular/src/forms/datepicker/datepicker-action-buttons.ts
Outdated
Show resolved
Hide resolved
kevinbuhmann
reviewed
Jan 9, 2025
kevinbuhmann
reviewed
Jan 9, 2025
projects/angular/src/forms/datepicker/providers/date-navigation.service.ts
Outdated
Show resolved
Hide resolved
kevinbuhmann
reviewed
Jan 9, 2025
projects/angular/src/forms/datepicker/providers/date-navigation.service.ts
Outdated
Show resolved
Hide resolved
kevinbuhmann
reviewed
Jan 9, 2025
projects/angular/src/forms/datepicker/datepicker-action-buttons.ts
Outdated
Show resolved
Hide resolved
kevinbuhmann
approved these changes
Jan 9, 2025
Co-authored-by: Kevin Buhmann <[email protected]>
dtsanevmw
approved these changes
Jan 9, 2025
This PR introduces visual changes: 34e3d2c
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: CDE-2497
What is the new behavior?
Confirmation action buttons (apply & cancel buttons) will be shown based on feature flag.
Does this PR introduce a breaking change?
Other information