Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(buttons): replace click with active tokens #1638

Merged

Conversation

valentin-mladenov
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Buttons are using status click tokens for active background color.

Issue Number: CDE-2473, CDE-2475

What is the new behavior?

Adding active interaction status tokens.
Buttons are using status active tokens for active background color.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@valentin-mladenov valentin-mladenov requested a review from a team December 6, 2024 11:51
@valentin-mladenov valentin-mladenov self-assigned this Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@valentin-mladenov
Copy link
Contributor Author

valentin-mladenov commented Dec 6, 2024

Related to vmware-clarity/core#340

@kevinbuhmann kevinbuhmann changed the title fix(buttons): repalce click with active tokens fix(buttons): replace click with active tokens Dec 6, 2024
@valentin-mladenov valentin-mladenov marked this pull request as ready for review December 6, 2024 13:46
@valentin-mladenov valentin-mladenov merged commit d786b0a into main Dec 11, 2024
10 checks passed
@valentin-mladenov valentin-mladenov deleted the update-interaction-tokens-overrides_cde-2473_cde-2475 branch December 11, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants