Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datagrid): add ability to unsort datagrid colums #1617

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

valentin-mladenov
Copy link
Contributor

@valentin-mladenov valentin-mladenov commented Nov 13, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Once turned on column sort can only be rotated between ASC and DESC when clicking on the column, but can't be turned off.

Issue Number: CDE-2439, CDE-2416

What is the new behavior?

Column sort can be turned off by clicking third time on the column.
The feature can be turned on by clrDgEnableUnsortColumns flag on datagrid level for entire datagrid.
The feature can be turned on/off per column by clrDgDisableUnsort flag on column level.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

github-actions bot commented Nov 13, 2024

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@valentin-mladenov
Copy link
Contributor Author

follow up of #1612

@valentin-mladenov valentin-mladenov changed the title feat(datagrid): add option to disable column unsort feat(datagrid): add ability to unsort datagrid colums Dec 11, 2024
@valentin-mladenov valentin-mladenov self-assigned this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants