-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datagrid): add ability to unsort datagrid colums #1617
Draft
valentin-mladenov
wants to merge
13
commits into
main
Choose a base branch
from
datagrid-column-disable-no-sort_cde-2439
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you, 🤖 Clarity Release Bot |
follow up of #1612 |
valentin-mladenov
changed the title
feat(datagrid): add option to disable column unsort
feat(datagrid): add ability to unsort datagrid colums
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Once turned on column sort can only be rotated between
ASC
andDESC
when clicking on the column, but can't be turned off.Issue Number: CDE-2439, CDE-2416
What is the new behavior?
Column sort can be turned off by clicking third time on the column.
The feature can be turned on by
clrDgEnableUnsortColumns
flag on datagrid level for entire datagrid.The feature can be turned on/off per column by
clrDgDisableUnsort
flag on column level.Does this PR introduce a breaking change?
Other information