feat(side-panel): pinnable and inline side panel #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @Jinnie,
Thank you, 🤖 Clarity Release Bot |
|
This PR introduces visual changes: 2eb00bf |
Jinnie
force-pushed
the
jinnie/sidebar-pinnable
branch
from
1af7f2c to
90483e8
Compare
|
This PR introduces visual changes: c942c34 |
kevinbuhmann
changed the title
|
This PR introduces visual changes: a966cd8 |
|
This PR introduces visual changes: 78f0b1a |
valentin-mladenov
requested changes
Dec 12, 2024
Comment on lines
+31
to
+39
| <button | ||
| type="button" | ||
| [attr.aria-label]="commonStrings.keys.sidePanelPin" | ||
| class="pinnable" | ||
| *ngIf="pinnable" | ||
| (click)="togglePinned()" | ||
| > | ||
| <cds-icon [attr.shape]="pinned ? 'unpin' : 'pin'"></cds-icon> | ||
| </button> |
There was a problem hiding this comment.
Make no sense side-panel logic to be inside modal.
Comment on lines
+110
to
+124
| get pinned(): boolean { | ||
| return this._pinned; | ||
| } | ||
|
|
||
| set pinned(pinned: boolean) { | ||
| if (this.pinnable) { | ||
| this._pinned = pinned; | ||
| if (pinned) { | ||
| this.displaySideBySide(); | ||
| } else { | ||
| this.displayOverlapping(); | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Make no sense side-panel logic to be inside modal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information