-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(date-picker): add option to show week numbers #1605
base: main
Are you sure you want to change the base?
feat(date-picker): add option to show week numbers #1605
Conversation
- add input to include week numbers in the calendar component (opt-in) Close: vmware-clarity#1307 Signed-off-by: Martin Brom <[email protected]>
Signed-off-by: Martin Brom <[email protected]>
Signed-off-by: Martin Brom <[email protected]>
@martinbrom, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
👋 @martinbrom,
Thank you, 🤖 Clarity Release Bot |
@martinbrom, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
Hello, @martinbrom, Thank you for your contribution. Could you run "npm run lint:fix" so the builds can complete? |
Signed-off-by: Martin Brom <[email protected]>
Signed-off-by: Martin Brom <[email protected]>
@martinbrom, VMware has approved your signed contributor license agreement. |
Hello, We'll need to pass it trough design and a11y in order to have a complete feature that we can merge and we will get back to you. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: see #1307 and the respective discussion thread
What is the new behavior?
The date container allows enabling the week number display in the daypicker (via input). This behavior is opt-in and does not break existing datepickers.
Does this PR introduce a breaking change?
Other information
I will also adapt the documentation after we agree on an acceptable solution.