Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(date-picker): add option to show week numbers #1605

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

martinbrom
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: see #1307 and the respective discussion thread

What is the new behavior?

The date container allows enabling the week number display in the daypicker (via input). This behavior is opt-in and does not break existing datepickers.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

I will also adapt the documentation after we agree on an acceptable solution.

- add input to include week numbers in the calendar component (opt-in)

Close: vmware-clarity#1307

Signed-off-by: Martin Brom <[email protected]>
@vmwclabot
Copy link

@martinbrom, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

Copy link
Contributor

github-actions bot commented Oct 29, 2024

👋 @martinbrom,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@vmwclabot
Copy link

@martinbrom, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@dtsanevmw
Copy link
Contributor

Hello, @martinbrom,

Thank you for your contribution. Could you run "npm run lint:fix" so the builds can complete?

@kevinbuhmann kevinbuhmann changed the title feat(date-picker): adds the option to show week numbers feat(date-picker): add option to show week numbers Oct 30, 2024
@vmwclabot
Copy link

@martinbrom, VMware has approved your signed contributor license agreement.

@dtsanevmw
Copy link
Contributor

Hello,

We'll need to pass it trough design and a11y in order to have a complete feature that we can merge and we will get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants