Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stepper): separate header panel from accordion, update icons and number positions #1583

Merged
merged 15 commits into from
Oct 15, 2024

Conversation

valentin-mladenov
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Success and error icons are replaceing the step number upon event.

Issue Number: CDE-1211

What is the new behavior?

Success and error icons have reserved space before step number and are not replacing it.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

github-actions bot commented Oct 7, 2024

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

Copy link
Contributor

github-actions bot commented Oct 7, 2024

This PR introduces visual changes: 57d028c
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout update-stepper-behaviour_cde-1211
git fetch https://github.com/vmware-clarity/ng-clarity.git 57d028ccb003dc6af8935b6afd4c97f9d9b3fd2f
git cherry-pick 57d028ccb003dc6af8935b6afd4c97f9d9b3fd2f
git push

Copy link
Contributor

github-actions bot commented Oct 8, 2024

This PR introduces visual changes: e6a89ff
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout update-stepper-behaviour_cde-1211
git fetch https://github.com/vmware-clarity/ng-clarity.git e6a89ff9e027637935063a2c9f92aa15bd9f9bf4
git cherry-pick e6a89ff9e027637935063a2c9f92aa15bd9f9bf4
git push

@valentin-mladenov valentin-mladenov marked this pull request as ready for review October 9, 2024 07:39
@valentin-mladenov valentin-mladenov requested a review from a team October 9, 2024 07:39
@dtsanevmw
Copy link
Contributor

It's good also to rename the title of the PR to point that we are doing that separation

Copy link
Contributor

github-actions bot commented Oct 9, 2024

This PR introduces visual changes: 9b7daa0
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout update-stepper-behaviour_cde-1211
git fetch https://github.com/vmware-clarity/ng-clarity.git 9b7daa039c8a2ceb8cf0f39ae3360cc0b6d55dea
git cherry-pick 9b7daa039c8a2ceb8cf0f39ae3360cc0b6d55dea
git push

Copy link
Contributor

This PR introduces visual changes: 1ea36c6
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout update-stepper-behaviour_cde-1211
git fetch https://github.com/vmware-clarity/ng-clarity.git 1ea36c65da949eec2092ee8e6254dcb4378df68e
git cherry-pick 1ea36c65da949eec2092ee8e6254dcb4378df68e
git push

@valentin-mladenov valentin-mladenov changed the title feat(stepper): update header button icons and number position feat(stepper): separate header panel from accordion, update icons and number position Oct 15, 2024
@valentin-mladenov valentin-mladenov changed the title feat(stepper): separate header panel from accordion, update icons and number position feat(stepper): separate header panel from accordion, update icons and number positions Oct 15, 2024
web-flow and others added 2 commits October 15, 2024 10:17
# Conflicts:
#	tests/snapshots/chromium/stepper/stepper--stepper-alignment-test-core-dark.png
#	tests/snapshots/chromium/stepper/stepper--stepper-alignment-test-core-light.png
#	tests/snapshots/chromium/stepper/stepper--stepper-core-dark.png
#	tests/snapshots/chromium/stepper/stepper--stepper-core-light.png
#	tests/snapshots/chromium/stepper/stepper--stepper-panel-status-indicators-core-dark.png
#	tests/snapshots/chromium/stepper/stepper--stepper-panel-status-indicators-core-light.png
#	tests/snapshots/chromium/stepper/stepper--stepper-with-previous-button-core-dark.png
#	tests/snapshots/chromium/stepper/stepper--stepper-with-previous-button-core-light.png
#	tests/snapshots/firefox/stepper/stepper--stepper-alignment-test-core-dark.png
#	tests/snapshots/firefox/stepper/stepper--stepper-alignment-test-core-light.png
#	tests/snapshots/firefox/stepper/stepper--stepper-core-dark.png
#	tests/snapshots/firefox/stepper/stepper--stepper-core-light.png
#	tests/snapshots/firefox/stepper/stepper--stepper-panel-status-indicators-core-dark.png
#	tests/snapshots/firefox/stepper/stepper--stepper-panel-status-indicators-core-light.png
#	tests/snapshots/firefox/stepper/stepper--stepper-with-previous-button-core-dark.png
#	tests/snapshots/firefox/stepper/stepper--stepper-with-previous-button-core-light.png
Copy link
Contributor

This PR introduces visual changes: 0611072
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout update-stepper-behaviour_cde-1211
git fetch https://github.com/vmware-clarity/ng-clarity.git 06110721252f9dfa945c1548ebadaaf1861750dd
git cherry-pick 06110721252f9dfa945c1548ebadaaf1861750dd
git push

@valentin-mladenov valentin-mladenov merged commit e684541 into main Oct 15, 2024
8 checks passed
@valentin-mladenov valentin-mladenov deleted the update-stepper-behaviour_cde-1211 branch October 15, 2024 08:20
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants