-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stepper): separate header panel from accordion, update icons and number positions #1583
Conversation
Thank you, 🤖 Clarity Release Bot |
This PR introduces visual changes: 57d028c
|
This PR introduces visual changes: e6a89ff
|
It's good also to rename the title of the PR to point that we are doing that separation |
This PR introduces visual changes: 9b7daa0
|
This PR introduces visual changes: 1ea36c6
|
# Conflicts: # tests/snapshots/chromium/stepper/stepper--stepper-alignment-test-core-dark.png # tests/snapshots/chromium/stepper/stepper--stepper-alignment-test-core-light.png # tests/snapshots/chromium/stepper/stepper--stepper-core-dark.png # tests/snapshots/chromium/stepper/stepper--stepper-core-light.png # tests/snapshots/chromium/stepper/stepper--stepper-panel-status-indicators-core-dark.png # tests/snapshots/chromium/stepper/stepper--stepper-panel-status-indicators-core-light.png # tests/snapshots/chromium/stepper/stepper--stepper-with-previous-button-core-dark.png # tests/snapshots/chromium/stepper/stepper--stepper-with-previous-button-core-light.png # tests/snapshots/firefox/stepper/stepper--stepper-alignment-test-core-dark.png # tests/snapshots/firefox/stepper/stepper--stepper-alignment-test-core-light.png # tests/snapshots/firefox/stepper/stepper--stepper-core-dark.png # tests/snapshots/firefox/stepper/stepper--stepper-core-light.png # tests/snapshots/firefox/stepper/stepper--stepper-panel-status-indicators-core-dark.png # tests/snapshots/firefox/stepper/stepper--stepper-panel-status-indicators-core-light.png # tests/snapshots/firefox/stepper/stepper--stepper-with-previous-button-core-dark.png # tests/snapshots/firefox/stepper/stepper--stepper-with-previous-button-core-light.png
This PR introduces visual changes: 0611072
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Success and error icons are replaceing the step number upon event.
Issue Number: CDE-1211
What is the new behavior?
Success and error icons have reserved space before step number and are not replacing it.
Does this PR introduce a breaking change?
Other information