Skip to content

Commit

Permalink
chore(ci): clean up netlify deploy commands (#1552)
Browse files Browse the repository at this point in the history
- Use `--site` argument.
- Remove `NETLIFY_SITE_ID` environment variables.
- Remove support the v17 beta docs site since that's not needed anymore.
  • Loading branch information
kevinbuhmann authored Sep 10, 2024
1 parent d2a7316 commit f0906be
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/pr-preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,5 @@ jobs:
if: ${{steps.download-docs.outputs.found_artifact == 'true'}}
timeout-minutes: 5
env:
NETLIFY_SITE_ID: ${{secrets.NETLIFY_SITE_ID}}
NETLIFY_AUTH_TOKEN: ${{secrets.NETLIFY_AUTH_TOKEN}}
run: npx netlify-cli deploy --alias ${{steps.get-pr-event.outputs.pullRequestNumber}}
run: npx netlify-cli deploy --site storybook-clarity-design --alias ${{steps.get-pr-event.outputs.pullRequestNumber}}
3 changes: 1 addition & 2 deletions .github/workflows/release-preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,5 @@ jobs:
continue-on-error: true
timeout-minutes: 5
env:
NETLIFY_SITE_ID: ${{secrets.NETLIFY_SITE_ID}}
NETLIFY_AUTH_TOKEN: ${{secrets.NETLIFY_AUTH_TOKEN}}
run: npx netlify-cli deploy
run: npx netlify-cli deploy --site storybook-clarity-design
3 changes: 1 addition & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,5 @@ jobs:
continue-on-error: true
timeout-minutes: 5
env:
NETLIFY_SITE_ID: ${{secrets.NETLIFY_SITE_ID}}
NETLIFY_AUTH_TOKEN: ${{secrets.NETLIFY_AUTH_TOKEN}}
run: npx netlify-cli deploy $([[ $GITHUB_REF_NAME == "main" ]] && echo "--prod" || ([[ $GITHUB_REF_NAME == "beta" ]] && echo "--prod --site v17-storybook-clarity-design" || echo "alias $GITHUB_REF_NAME"))
run: npx netlify-cli deploy --site storybook-clarity-design $([[ $GITHUB_REF_NAME == "main" ]] && echo "--prod")

0 comments on commit f0906be

Please sign in to comment.