feat(breadcrumbs): removed commented code

vmware-clarity · Dec 6, 2024 · e79c4cb · e79c4cb
1 parent a7dd25e
commit e79c4cb
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 6 deletions.
diff --git a/projects/angular/clarity.api.md b/projects/angular/clarity.api.md
@@ -530,8 +530,6 @@ export enum ClrAxis {
 
 // @public (undocumented)
 export class ClrBreadcrumbItem {
-    // (undocumented)
-    delimiter: string;
     // (undocumented)
     static ɵcmp: i0.ɵɵComponentDeclaration<ClrBreadcrumbItem, "clr-breadcrumb-item", never, {}, {}, never, ["*"], false, never>;
     // (undocumented)

diff --git a/projects/angular/src/layout/breadcrumbs/_breadcrumbs.clarity.scss b/projects/angular/src/layout/breadcrumbs/_breadcrumbs.clarity.scss
@@ -18,7 +18,7 @@
   .clr-breadcrumb-item {
     display: flex;
     align-items: center;
-    min-height: 24px; //tokens.$cds-global-space-24; --> TO DO: Add token to clarity core
+    min-height: mixins.baselinePx(24);
     font-family: breadcrumb-variables.$clr-breadcrumb-font-family;
     color: breadcrumb-variables.$clr-breadcrumb-link-color;
     @include mixins.generate-typography-token('SECONDARY-13-RG-CPT');

diff --git a/projects/angular/src/layout/breadcrumbs/_properties.breadcrumbs.scss b/projects/angular/src/layout/breadcrumbs/_properties.breadcrumbs.scss
@@ -10,7 +10,6 @@
 @include mixins.exports('breadcrumbs.properties') {
   :root [cds-theme] {
     --clr-breadcrumb-link-color: #{tokens.$cds-alias-object-interaction-background-highlight};
-    // --clr-breadcrumb-item-height: #{tokens.$cds-global-space-24};
     --clr-breadcrumb-item-space: #{tokens.$cds-global-space-8};
     --clr-breadcrumb-font-weight: #{tokens.$cds-global-typography-font-weight-regular};
     --clr-breadcrumb-font-size: #{tokens.$cds-alias-typography-secondary-font-size};

diff --git a/projects/angular/src/layout/breadcrumbs/breadcrumbs.html b/projects/angular/src/layout/breadcrumbs/breadcrumbs.html
@@ -1,5 +1,5 @@
 <div role="list" class="clr-breadcrumb-menu">
-  <ng-template [ngIf]="items?.length">
+  <ng-container *ngIf="items?.length">
     <clr-breadcrumb-item *ngIf="items.length > max && !isExpanded">
       <span (click)="expand()" (keydown)="expand()" class="clr-breadcrumb-expand">
         <cds-icon shape="ellipsis-horizontal"></cds-icon>
@@ -13,5 +13,5 @@
         <span *ngIf="isLastItem" aria-current="page">{{ breadcrumb?.label }}</span>
       </clr-breadcrumb-item>
     </ng-container>
-  </ng-template>
+  </ng-container>
 </div>