Skip to content

Commit

Permalink
fix(tokens): temp overrride for warning status dark color for dark th…
Browse files Browse the repository at this point in the history
…eme (#1611)

## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?
`--cds-alias-status-warning-dark` have `--cds-global-color-ochre-700`
for dark theme.

Issue Number: CDE-2402

## What is the new behavior?
`--cds-alias-status-warning-dark` have `--cds-global-color-ochre-600`
for dark theme.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

## Other information

---------

Co-authored-by: GitHub <[email protected]>
  • Loading branch information
valentin-mladenov and web-flow authored Nov 6, 2024
1 parent d1ae4a9 commit aeec806
Show file tree
Hide file tree
Showing 9 changed files with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions projects/ui/src/temp-overrides.scss
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
[cds-theme~='dark'] {
--cds-alias-utility-gray: #{tokens.$cds-global-color-construction-300};

--cds-alias-status-warning-dark: #{tokens.$cds-global-color-ochre-600};
--cds-alias-status-warning-tint: #{tokens.$cds-global-color-ochre-900};
--cds-alias-status-danger-tint: #{tokens.$cds-global-color-red-900};

Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/chromium/button/button--showcase-core-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/firefox/button/button--showcase-core-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit aeec806

Please sign in to comment.