-
Notifications
You must be signed in to change notification settings - Fork 80
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(alerts): update dark theme colors (#1596)
## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? Alert `--clr-alert-warning-font-color` point to `--cds-global-color-black`. Issue Number: CDE-2339 ## What is the new behavior? Dark theme overrides `--cds-alias-status-warning-tint` point to `--cds-global-color-ochre-900` `--cds-alias-status-danger-tint` point to `--cds-global-color-red-900` Alert `--clr-alert-warning-font-color` point to `--cds-alias-typography-color-500`. ## Does this PR introduce a breaking change? - [ ] Yes - [x] No ## Other information --------- Co-authored-by: GitHub <[email protected]>
- Loading branch information
1 parent
e684541
commit 6a57512
Showing
14 changed files
with
4 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+1.14 KB
(100%)
tests/snapshots/chromium/alert/standard-alerts--alert-core-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.27 KB
(100%)
tests/snapshots/chromium/alert/standard-alerts--closable-core-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.37 KB
(100%)
tests/snapshots/chromium/alert/standard-alerts--different-icon-core-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.02 KB
(100%)
tests/snapshots/chromium/alert/standard-alerts--small-core-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.94 KB
(100%)
tests/snapshots/chromium/alert/standard-alerts--with-actions-core-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+148 Bytes
(100%)
tests/snapshots/chromium/login/login--login-core-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+810 Bytes
(100%)
tests/snapshots/firefox/alert/standard-alerts--alert-core-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+798 Bytes
(100%)
tests/snapshots/firefox/alert/standard-alerts--closable-core-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+788 Bytes
(100%)
tests/snapshots/firefox/alert/standard-alerts--different-icon-core-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+623 Bytes
(100%)
tests/snapshots/firefox/alert/standard-alerts--small-core-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.19 KB
(100%)
tests/snapshots/firefox/alert/standard-alerts--with-actions-core-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.