Skip to content

Commit

Permalink
fix(alerts): update dark theme colors (#1596)
Browse files Browse the repository at this point in the history
## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?
Alert `--clr-alert-warning-font-color` point to `--cds-global-color-black`.

Issue Number: CDE-2339

## What is the new behavior?
Dark theme overrides
`--cds-alias-status-warning-tint` point to `--cds-global-color-ochre-900`
`--cds-alias-status-danger-tint` point to `--cds-global-color-red-900`

Alert `--clr-alert-warning-font-color` point to `--cds-alias-typography-color-500`.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

## Other information

---------

Co-authored-by: GitHub <[email protected]>
  • Loading branch information
valentin-mladenov and web-flow authored Oct 17, 2024
1 parent e684541 commit 6a57512
Show file tree
Hide file tree
Showing 14 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion projects/angular/src/emphasis/alert/_properties.alert.scss
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
// Warning type
// Usage: ./_alert.clarity.scss
--clr-alert-warning-bg-color: #{tokens.$cds-alias-status-warning-tint};
--clr-alert-warning-font-color: #{tokens.$cds-global-color-black};
--clr-alert-warning-font-color: #{tokens.$cds-alias-typography-color-500};
--clr-alert-warning-border-color: #{tokens.$cds-alias-status-warning};
--clr-alert-warning-icon-color: var(--clr-alert-warning-font-color);
--clr-alert-warning-close-icon-color: var(--clr-alert-warning-font-color);
Expand Down
3 changes: 3 additions & 0 deletions projects/ui/src/temp-overrides.scss
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@
[cds-theme~='dark'] {
--cds-alias-utility-gray: #{tokens.$cds-global-color-construction-300};

--cds-alias-status-warning-tint: #{tokens.$cds-global-color-ochre-900};
--cds-alias-status-danger-tint: #{tokens.$cds-global-color-red-900};

--cds-alias-object-container-backdrop-background: #{tokens.$cds-alias-object-opacity-300};
--cds-alias-object-interaction-background-hover: #{tokens.$cds-global-color-construction-800};
--cds-alias-object-interaction-background-active: #{tokens.$cds-global-color-construction-600};
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/chromium/login/login--login-core-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/firefox/alert/standard-alerts--alert-core-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/firefox/alert/standard-alerts--small-core-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/firefox/login/login--login-core-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 6a57512

Please sign in to comment.