Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add filtering support for twingate resources datasource #42

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

vmanilo
Copy link
Owner

@vmanilo vmanilo commented Dec 17, 2023

Resolves extending datasource

Changes

  • added optional attributes

@coveralls
Copy link

coveralls commented Dec 18, 2023

Pull Request Test Coverage Report for Build 7306475357

  • 58 of 84 (69.05%) changed or added relevant lines in 4 files are covered.
  • 1237 unchanged lines in 27 files lost coverage.
  • Overall coverage decreased (-21.1%) to 69.025%

Changes Missing Coverage Covered Lines Changed/Added Lines %
twingate/internal/client/query/resources-by-name-read.go 11 19 57.89%
twingate/internal/provider/datasource/resources.go 44 62 70.97%
Files with Coverage Reduction New Missed Lines %
twingate/internal/client/client.go 1 97.97%
twingate/internal/client/variables.go 2 98.71%
twingate/internal/client/query/resource-read.go 4 93.44%
twingate/internal/provider/datasource/helper.go 6 0.0%
twingate/internal/provider/datasource/converter.go 8 87.5%
twingate/internal/provider/resource/helper.go 15 60.78%
twingate/internal/provider/datasource/connectors.go 17 61.11%
twingate/internal/provider/datasource/security-policies.go 17 54.1%
twingate/internal/provider/datasource/users.go 17 65.85%
twingate/internal/provider/datasource/remote-networks.go 21 52.78%
Totals Coverage Status
Change from base Build 7198926585: -21.1%
Covered Lines: 4107
Relevant Lines: 5950

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants