Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[distributed] remove pynccl's redundant stream #11744

Merged
merged 3 commits into from
Jan 5, 2025

Conversation

cennn
Copy link
Contributor

@cennn cennn commented Jan 5, 2025

I've streamlined the PyNcclCommunicator codebase by removing redundant stream initializations and assignments.

Copy link

github-actions bot commented Jan 5, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@cennn cennn changed the title PyNcclCommunicator rm self.stream Optimize PyNcclCommunicator Stream Handling Jan 5, 2025
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the great work!

@youkaichao youkaichao changed the title Optimize PyNcclCommunicator Stream Handling [distributed] remove pynccl's redundant stream Jan 5, 2025
@youkaichao youkaichao enabled auto-merge (squash) January 5, 2025 12:25
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 5, 2025
@youkaichao
Copy link
Member

also cc @tlrmchlsmth

auto-merge was automatically disabled January 5, 2025 14:34

Head branch was pushed to by a user without write access

@youkaichao
Copy link
Member

merge as buildkite/fastcheck/pr/entrypoints-test succeeds.

@youkaichao youkaichao merged commit 635b897 into vllm-project:main Jan 5, 2025
78 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants