Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mypy] Forward pass function type hints in lora #11740

Merged
merged 6 commits into from
Jan 6, 2025

Conversation

lucas-tucker
Copy link
Contributor

@lucas-tucker lucas-tucker commented Jan 4, 2025

This PR adds mypy type hints for forward functions on subclasses of torch.nn.Module, which returns an output due to the forward pass paired with a Parameter bias.

#3680

lucast2021 added 2 commits January 4, 2025 08:02
Copy link

github-actions bot commented Jan 4, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

lucast2021 added 2 commits January 4, 2025 08:48
Signed-off-by: lucast2021 <[email protected]>
Signed-off-by: lucast2021 <[email protected]>
vllm/lora/layers.py Outdated Show resolved Hide resolved
lucast2021 added 2 commits January 5, 2025 10:16
Signed-off-by: lucast2021 <[email protected]>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) January 6, 2025 02:14
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 6, 2025
@DarkLight1337 DarkLight1337 merged commit 9c74971 into vllm-project:main Jan 6, 2025
70 checks passed
@lucas-tucker lucas-tucker deleted the lora-mypy branch January 6, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants