[VLM] Merged multi-modal processor for LLaVA-NeXT #11682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
This was referenced Jan 2, 2025
DarkLight1337
force-pushed
the
llava-next-mm-processor
branch
2 times, most recently
from
8035ddc to
67e50fd
Compare
Signed-off-by: DarkLight1337 <[email protected]>
DarkLight1337
force-pushed
the
llava-next-mm-processor
branch
from
67e50fd to
9bfbc82
Compare
DarkLight1337
added
the
ready
Signed-off-by: DarkLight1337 <[email protected]>
DarkLight1337
force-pushed
the
llava-next-mm-processor
branch
from
ce0a7dc to
24ec89c
Compare
Signed-off-by: DarkLight1337 <[email protected]>
|
Seems that llava-next test is failing... |
|
Fixed! |
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the merged multi-modal processor for LLaVA-NeXT. To avoid redundant code, I have introduced base classes
VisionEncoderInfoandBaseLlavaMultiModalProcessor.