Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Minor documentation fixes #11580

Merged
merged 2 commits into from
Dec 28, 2024
Merged

[Doc] Minor documentation fixes #11580

merged 2 commits into from
Dec 28, 2024

Conversation

DarkLight1337
Copy link
Member

This PR includes mostly formatting fixes to the documentation.

@DarkLight1337
Minor documentation fixes
831f9f0 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 28, 2024
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Dec 28, 2024
@DarkLight1337
Fix build error
6f994c0 
Signed-off-by: DarkLight1337 <[email protected]>
youkaichao
youkaichao approved these changes Dec 28, 2024
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@youkaichao youkaichao merged commit d427e5c into vllm-project:main Dec 28, 2024
33 checks passed
@DarkLight1337 DarkLight1337 deleted the minor-doc-fixes branch December 28, 2024 13:55
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
@DarkLight1337 @BKitor
[Doc] Minor documentation fixes (vllm-project#11580)
09cf234 
Signed-off-by: DarkLight1337 <[email protected]>
xcnick pushed a commit to xcnick/vllm that referenced this pull request Dec 31, 2024
@DarkLight1337 @xcnick
[Doc] Minor documentation fixes (vllm-project#11580)
4edd6a2 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: xcnick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youkaichao youkaichao youkaichao approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarkLight1337 @youkaichao