Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Model] Support InternLM2 Reward models #11571

Merged
merged 3 commits into from
Dec 28, 2024
Merged

[Model] Support InternLM2 Reward models #11571

merged 3 commits into from
Dec 28, 2024
+67 −1

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Dec 27, 2024 •
edited by github-actions bot
Loading

  • Add support for InternLM2 reward models

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Dec 27, 2024
DarkLight1337
DarkLight1337 approved these changes Dec 28, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 28, 2024 04:18
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 28, 2024
@DarkLight1337 DarkLight1337 merged commit d34be24 into vllm-project:main Dec 28, 2024
56 of 58 checks passed
@Isotr0py Isotr0py deleted the internlm-reward branch December 28, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Isotr0py @DarkLight1337