Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix for ROCM compressed tensor support #11561

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

selalipop
Copy link
Contributor

@selalipop selalipop commented Dec 27, 2024

ROCM codepaths for compressed tensor currently don't check if input_shape layer exists before access: this PR adds a basic check

FIX #11537

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@mgoin mgoin added quantization ready ONLY add when PR is ready to merge/full CI is needed labels Dec 27, 2024
@mgoin mgoin enabled auto-merge (squash) December 27, 2024 16:17
@mgoin mgoin merged commit ac79799 into vllm-project:main Dec 27, 2024
69 checks passed
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
xcnick pushed a commit to xcnick/vllm that referenced this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quantization ready ONLY add when PR is ready to merge/full CI is needed rocm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: FP8 W8A8 LLM Compressor Models fail to load in vLLM
3 participants