Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Deepseekv3 broke quantization for all other methods #11547

Merged
merged 2 commits into from
Dec 27, 2024
Merged

[BugFix] Deepseekv3 broke quantization for all other methods #11547

merged 2 commits into from
Dec 27, 2024
+52 −22

Conversation

robertgshaw2-neuralmagic
Copy link
Collaborator

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic commented Dec 27, 2024 •
edited by github-actions bot
Loading

SUMMARY:

  • fix quantization for MoE

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 27, 2024
@simon-mo simon-mo enabled auto-merge (squash) December 27, 2024 05:19
@simon-mo
Copy link
Collaborator

Will patch release after this

@simon-mo
Copy link
Collaborator

Merging as only AMD test are pending.

@simon-mo simon-mo disabled auto-merge December 27, 2024 06:23
@simon-mo simon-mo merged commit 2339d59 into main Dec 27, 2024
55 of 57 checks passed
@simon-mo simon-mo deleted the fix-moe-tests branch December 27, 2024 06:23
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
@robertgshaw2-neuralmagic @BKitor
[BugFix] Fix quantization for all other methods (vllm-project#11547)
ab12868
xcnick pushed a commit to xcnick/vllm that referenced this pull request Dec 31, 2024
@robertgshaw2-neuralmagic @xcnick
[BugFix] Fix quantization for all other methods (vllm-project#11547)
f010ec4 
Signed-off-by: xcnick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

@mgoin mgoin Awaiting requested review from mgoin

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertgshaw2-neuralmagic @simon-mo