Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Allow initializing KV cache transfer agent when using third-party library for disaggregated prefill #11480

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KuntaiDu
Copy link
Collaborator

@KuntaiDu KuntaiDu commented Dec 25, 2024

Allow initializing the KV cache transfer agent even when kv_parallel_size==1.

This is because, when using third-party library for disaggregated prefill, it's possible that it handles everything in the library (and thus it does not need to set kv_parallel_size>1), but we still need to initialize the agent to initialize third-party connector in the first place.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@KuntaiDu KuntaiDu requested a review from youkaichao December 25, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant