[V1][Core] Remove should_shutdown to simplify core process termination #11113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Michael Smith <[email protected]>
Signed-off-by: Tyler Michael Smith <[email protected]>
Signed-off-by: Tyler Michael Smith <[email protected]>
tlrmchlsmth
requested review from
WoosukKwon,
robertgshaw2-neuralmagic,
njhill,
ywang96,
comaniac and
alexm-neuralmagic
as code owners
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
robertgshaw2-neuralmagic
approved these changes
Dec 11, 2024
github-actions
bot
added
the
ready
elfiegg
pushed a commit
to elfiegg/vllm
that referenced
this pull request
Dec 12, 2024
vllm-project#11113) Signed-off-by: Tyler Michael Smith <[email protected]>
Akshat-Tripathi
pushed a commit
to krai/vllm
that referenced
this pull request
Dec 12, 2024
vllm-project#11113) Signed-off-by: Tyler Michael Smith <[email protected]> Signed-off-by: Akshat Tripathi <[email protected]>
sleepwalker2017
pushed a commit
to sleepwalker2017/vllm
that referenced
this pull request
Dec 13, 2024
vllm-project#11113) Signed-off-by: Tyler Michael Smith <[email protected]>
BKitor
pushed a commit
to BKitor/vllm
that referenced
this pull request
Dec 30, 2024
vllm-project#11113) Signed-off-by: Tyler Michael Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
should_shutdownmultiprocessing.Valuein favor of having one single process termination mechanism, which is an exception that handles both SIGINT and SIGTERM, and we need to handle SIGINT anyway.Tested manually that this shuts down correctly when setting
VLLM_ENABLE_V1_MULTIPROCESSING=1 VLLM_USE_V1=1using both a simple script (uses atexit -> shutdown() codepath) and usingvllm serve(sending both a SIGINT and SIGTERM)