Skip to content

Commit

Permalink
cruft removal
Browse files Browse the repository at this point in the history
  • Loading branch information
robertgshaw2-neuralmagic committed Jan 3, 2025
1 parent 80c751e commit 77cd7a5
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 11 deletions.
2 changes: 0 additions & 2 deletions vllm/entrypoints/llm.py
Original file line number Diff line number Diff line change
Expand Up @@ -225,8 +225,6 @@ def __init__(
# Logic to switch between engines is done at runtime instead of import
# to avoid import order issues
self.engine_class = self.get_engine_class()

# TODO(rob): enable mp by default (issue with fork vs spawn)
self.llm_engine = self.engine_class.from_engine_args(
engine_args, usage_context=UsageContext.LLM_CLASS)

Expand Down
2 changes: 0 additions & 2 deletions vllm/v1/engine/core_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,6 @@ class InprocClient(EngineCoreClient):
* pushes EngineCoreRequest directly into the EngineCore
* pulls EngineCoreOutputs by stepping the EngineCore
TODO: support asyncio-mode for debugging.
"""

def __init__(self, *args, **kwargs):
Expand Down
4 changes: 0 additions & 4 deletions vllm/v1/engine/llm_engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ def __init__(
use_cached_outputs: bool = False,
multiprocess_mode: bool = False,
) -> None:

# TODO: Can we avoid this?
self.model_config = vllm_config.model_config

# Tokenizer (+ ensure liveness if running in another process).
Expand Down Expand Up @@ -179,8 +177,6 @@ def step(self) -> List[RequestOutput]:

return request_outputs

# TODO(rob): Can we get rid of these?

def get_model_config(self):
return self.model_config

Expand Down
3 changes: 0 additions & 3 deletions vllm/v1/engine/processor.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,6 @@ def __init__(
cache_config.enable_prefix_caching
self.mm_hasher = MMHasher()

# TODO: run in an ThreadpoolExecutor or BackgroundProcess.
# This ideally should releases the GIL, so we should not block the
# asyncio loop while this is running.
def process_inputs(
self,
request_id: str,
Expand Down

0 comments on commit 77cd7a5

Please sign in to comment.