Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SmoothQuant offload bug #978

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix SmoothQuant offload bug #978

wants to merge 2 commits into from

Conversation

dsikka
Copy link
Collaborator

@dsikka dsikka commented Dec 15, 2024 •
edited
Loading

SUMMARY:

  • Offload/onload properly during SmoothQuant calibration

We may actually not need this change?
The issue is because of the following line:

scales = activation_scales.pow(self.smoothing_strength) / weight_scales.pow(
            1 - self.smoothing_strength
        )

i.e y/x

However, we use y.div_(x) when actually applying the smoothing scales, which does it in place and does not cause an issue.

Not 100% sure why one is ok and one is not

@dsikka
fix offload
d1a07fc 
Signed-off-by: Dipika <[email protected]>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

@dsikka dsikka marked this pull request as draft December 15, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylesayrs kylesayrs Awaiting requested review from kylesayrs

@rahul-tuli rahul-tuli Awaiting requested review from rahul-tuli

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dsikka