[WIP] AWQ initial implementation #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @rahul-tuli , any timeline about when AWQ will be shipped and merged? Thank you! |
kylesayrs
reviewed
Sep 15, 2024
| :param state: state to run AWQ on | ||
| :return: True on a successful run, False otherwise | ||
| """ | ||
| if self.end and self.end != -1: |
There was a problem hiding this comment.
Currently user can pass self.end == 0
Suggested change
| if self.end and self.end != -1: | |
| if not (self.end is None or self.end == -1): |
kylesayrs
reviewed
Sep 15, 2024
| balance_layers = mapping.balance_layers | ||
|
|
||
| activations = self.scales_[mapping.smooth_name].inps | ||
| module2inspect = smooth_layer |
There was a problem hiding this comment.
Not sure why there are two variable names
kylesayrs
reviewed
Sep 15, 2024
| w_mean = w_scale.mean(0) | ||
|
|
||
| # [STEP 2]: Compute per-channel mean of the input activation with chunking | ||
| # move inp to cpu to avoid memory leak |
There was a problem hiding this comment.
What operation causes the memory leak? Should the tensor be moved back to gpu after?
|
Closing as all the individual pieces; are now broken down into separate stacked diffs in #181 |
markmc
pushed a commit
to markmc/llm-compressor
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
"please provide a brief summary"
TEST PLAN:
"please outline how the changes were tested"