fix consecutive oneshot #898
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. |
kylesayrs
reviewed
Nov 7, 2024
kylesayrs
previously approved these changes
Nov 7, 2024
…-compressor into fix-consecutive-oneshot
|
I think this wont work until we allow decompression of the entire model |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Fix test that runs consecutive oneshots
TEST PLAN:
Pass test
Next todos:
Need a clean way to initialize recipe -- previously done by SparseAutoModelForCausalLM -> need on the second oneshot, so might be able to integrate on HFQuantizer side
model=first_tiny_modelshould be taken care by using HFQuantizer, not by loading in from the session