Pipeline generator steps #32
Conversation
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
scripts/pipeline_generator/step.py
Outdated
| class TestStep(BaseModel): | ||
| """This class represents a test step defined in the test configuration file.""" |
There was a problem hiding this comment.
why are these in this PR? do you want to test maybe unmarshaling these data structures?
There was a problem hiding this comment.
the method that unmarshal them from the yaml file would be in the next PR
There was a problem hiding this comment.
then why is this checked in in this PR? this is not referenced in this PR anywhere?
|
there is a conflict on the |
Signed-off-by: kevin <[email protected]>
|
done! I've removed the 2 classes that are not referenced in this PR yet, and also resolved conflict |
scripts/pipeline_generator/step.py
Outdated
| class BuildkiteBlockStep(BaseModel): | ||
| """This class represents a block step in Buildkite format.""" | ||
| block: str | ||
| depends_on: Optional[str] = "build" |
There was a problem hiding this comment.
maybe declare a global constant for "build"?
scripts/pipeline_generator/step.py
Outdated
| if char in ", ": | ||
| step_key += "-" |
There was a problem hiding this comment.
maybe this should be like "if the last char was -, just skip this char"? then you do not need the replace(", ", ","), and can more gracefully handle cases like ,, or , (double spaces)?
Signed-off-by: kevin <[email protected]>
Define step types and helper functions to help create step.