Merge pull request #26 from vivid-planet/image-versioning

Use appVersion from chart.yaml for tagging the built image
vivid-planet · Nov 28, 2023 · 20cb239 · 20cb239
2 parents 7723b40 + 79959a5
commit 20cb239
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/.github/workflows/build-and-publish.yml b/.github/workflows/build-and-publish.yml
@@ -11,7 +11,7 @@ jobs:
         runs-on: ubuntu-latest
         env:
             IMAGE_NAME: "vividplanet/swr-cache-proxy"
-            TAGS: "v1"
+            TAGS: $(yq e '.appVersion' charts/swr-cache-proxy/Chart.yaml)
         steps:
             - run: echo "${{ github.actor }}"
 

diff --git a/charts/swr-cache-proxy/values.yaml b/charts/swr-cache-proxy/values.yaml
@@ -5,8 +5,6 @@ replicaCount: 2
 image:
   repository: vividplanet/swr-cache-proxy
   pullPolicy: Always
-  # Overrides the image tag whose default is the chart appVersion.
-  tag: "v1" # TODO use appVersion
 
 imagePullSecrets: []
 nameOverride: ""