Add ErrorHandler to site
#639
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
dkarnutsch,
fraxachun,
johnnyomair,
manuelblum and
nsams
thomasdax98
added
the
recommended-change
|
fraxachun
approved these changes
Dec 30, 2024
nsams
approved these changes
Dec 30, 2024
johnnyomair
reviewed
Jan 7, 2025
| export function ErrorHandler({ children }: PropsWithChildren) { | ||
| function onError(error: Error, errorInfo: React.ErrorInfo) { | ||
| if (process.env.NODE_ENV === "development") { | ||
| console.error("Error caught by error handler", error, errorInfo.componentStack); |
There was a problem hiding this comment.
Do we need this console log if we re-throw the error?
johnnyomair
approved these changes
Jan 7, 2025
dkarnutsch
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
see vivid-planet/comet#2281
By switching to SSR instead of SSG, an error thrown in a block causes the entire page to crash (white screen). To avoid this, errors in the block are caught and handled in the ErrorHandler.
In development, the error is still thrown. In production, blocks with errors are simply hidden. A tool like Sentry should be configured where the error can be logged.