Static rendering #576
Open
Static rendering #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraxachun
added
the
recommended-change
auto-assign
bot
requested review from
dkarnutsch,
manuelblum and
thomasdax98
nsams
reviewed
Dec 2, 2024
| return ( | ||
| <html lang={scope.language}> | ||
| <body> | ||
| <p>Page not found (Scope {JSON.stringify(scope)}).</p> |
There was a problem hiding this comment.
outputting the scope doesn't belong into starter. But localized messages would. (can also be a different PR)
thomasdax98
previously approved these changes
Dec 3, 2024
Du to access to cookies in preview mode
|
@nsams @thomasdax98 I had to remove |
johnnyomair
reviewed
Dec 4, 2024
johnnyomair
approved these changes
Dec 11, 2024
thomasdax98
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
vivid-planet/comet#2836 for Starter.
Adds basic styling for NotFound: