add folderId to environment variables #233
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliawegmayr
force-pushed
the
add-folderID-to-envVars
branch
from
c799c55 to
6503084
Compare
raphaelblum
reviewed
Dec 9, 2024
.env
Outdated
| @@ -85,3 +85,4 @@ NEXT_PUBLIC_CAMPAIGN_IS_PREVIEW=false | |||
| REDIRECT_URL_FOR_IMPORT=$SITE_URL | |||
| BREVO_ALLOWED_REDIRECT_URL=http://${DEV_DOMAIN:-localhost}${WORKAROUND_DOTENV_ISSUE}:${SITE_PORT} | |||
| CAMPAIGNS_FRONTEND_URL=http://${DEV_DOMAIN:-localhost}${WORKAROUND_DOTENV_ISSUE}:${SITE_PORT} # doesn't work, TODO: add actual mailing frontend | |||
| BREVO_FOLDER_ID= | |||
There was a problem hiding this comment.
I would either set it to 1 here or not set it at all
| @@ -15,6 +15,7 @@ export interface BrevoModuleConfig { | |||
| }; | |||
| allowedRedirectUrl: string; | |||
| redirectUrlForImport: string; | |||
| folderId: number; | |||
There was a problem hiding this comment.
this is a breaking change.
I would make it optional and set it to default 1 in the package, not in the demo
| try { | ||
| const contactList = { | ||
| name: title, | ||
| folderId: 1, // folderId is required, folder #1 is created by default | ||
| folderId: folderId, |
There was a problem hiding this comment.
Suggested change
| folderId: folderId, | |
| folderId, |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add folderId to environment variables to allow overriding default value 1.
Changeset
[x] I have verified if my change requires a changeset
Related tasks and documents
https://vivid-planet.atlassian.net/browse/COM-1280