Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add folder id to config #159

Open
wants to merge 14 commits into
base: next
Choose a base branch
from
Open

Add folder id to config #159

wants to merge 14 commits into from

Conversation

juliawegmayr
Copy link
Contributor

@juliawegmayr juliawegmayr commented Nov 19, 2024

Description

Add folderId to BrevoConfig to enable overwriting the default folderId (=1) in case the folder was deleted.

Screenshots/screencasts

Screenshot 2024-11-19 at 13 58 30
Screenshot 2024-11-19 at 13 59 12

Changeset

[x] I have verified if my change requires a changeset

Related tasks and documents

COM-1280

@juliawegmayr juliawegmayr changed the base branch from main to next November 19, 2024 12:56
@juliawegmayr juliawegmayr marked this pull request as ready for review November 19, 2024 13:01
@auto-assign auto-assign bot requested a review from raphaelblum November 19, 2024 13:01
@raphaelblum
Copy link
Collaborator

raphaelblum commented Nov 20, 2024

Could you set it as 1 by default in the admin? (when you first open the form without data)
In almost all cases this will remain 1.

I think a small info icon with a text describing that this should almost always be 1 as long as you had not configured anything special here would also be great

@juliawegmayr
Copy link
Contributor Author

juliawegmayr commented Nov 21, 2024

Could you set it as 1 by default in the admin? (when you first open the form without data) In almost all cases this will remain 1.

I think a small info icon with a text describing that this should almost always be 1 as long as you had not configured anything special here would also be great

Sure! Thanks for the input! @raphaelblum
Add info icon: 4f89d4d
Add defaultValue to the form field: 537ef29

@RainbowBunchie
Copy link
Contributor

Could you set it as 1 by default in the admin? (when you first open the form without data) In almost all cases this will remain 1.

I think a small info icon with a text describing that this should almost always be 1 as long as you had not configured anything special here would also be great

@raphaelblum would you also save the default folder in the database and make the field required? 🤔 I think it is misleading to set the default to 1 but the field is also nullable and if not set "1" is used per default anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants