COM-964 Add multiselect to choose test contacts (Depends on: #78) #101
Conversation
juliawegmayr
force-pushed
the
add-multiselect-to-choose-test-contacts
branch
from
f1c9cc5 to
14293f8
Compare
juliawegmayr
force-pushed
the
add-multiselect-to-choose-test-contacts
branch
from
14293f8 to
fbd842d
Compare
juliawegmayr
force-pushed
the
add-multiselect-to-choose-test-contacts
branch
from
29d628e to
f2321fe
Compare
juliawegmayr
force-pushed
the
add-multiselect-to-choose-test-contacts
branch
from
f2321fe to
76b0b6a
Compare
| async function submitTestEmails({ testEmails }: FormProps) { | ||
| const emailsArray = testEmails.trim().split("\n"); | ||
| const { data, loading, error } = useQuery(brevoTestContactsSelectQuery, { | ||
| variables: { offset: 0, limit: 50, email: "", scope }, |
There was a problem hiding this comment.
Why is email set here?
I doubt there will be more than 50 tests contacts but I guess this should be handled somehow... @raphaelblum what do you think about the limit?
There was a problem hiding this comment.
I agree just loading 50 doesn't look clean. Couldn't we use Autocomplete for this?
https://storybook.comet-dxp.com/?path=/story/docs-hooks-useasyncoptionsprops--autocomplete
There was a problem hiding this comment.
I think I addressed this issue about reloading values in an async select before (in comet), I do not know if it is already possible to load more (on scrolling, input change..)?
There was a problem hiding this comment.
I removed the email: 4115626
As discussed, I changed the limit to 100: 0a664db and added a check in the api to prevent creating more than 100 contacts: 13d2f5f, 5e991c3
In the frontend the button to create a new contact is disabled as soon as there are 100 contacts and a tooltip gives information about that: f2403cb
|
At the moment, there is a text field for entering test contacts manually.
The email dispatch only works if the entered email is part of a contact list. To resolve this, the textfield is replaced with a multi-select field that only displays users from the test contact list.
Changes:
Replaced the free-text field with a multi-select field.
The multi-select field is now populated with users from the test contact list only.
Screenshots/screencasts
Changeset
[x] I have verified if my change requires a changeset
Further information
https://vivid-planet.atlassian.net/browse/COM-964