Merge pull request #5 from vivekpshaligram/phase-2

remove update per page abstract function

README.md

@@ -16,7 +16,7 @@ Add the dependency
 
 ```
 dependencies {
-    implementation 'com.github.vivekpshaligram:sit-common:2.0.3'
+    implementation 'com.github.vivekpshaligram:sit-common:2.0.4'
 }
 ```
 

app/src/main/java/com/sit/sociallogin/ui/LoginViewModel.kt

@@ -23,7 +23,4 @@ class LoginViewModel @Inject constructor(val repository: Repository) : BaseViewM
         }
     }
 
-    override fun updatePerPage() {
-
-    }
 }

sit-common/build.gradle.kts

@@ -73,7 +73,7 @@ afterEvaluate {
                 from (components["release"])
                 groupId = "com.github.sit"
                 artifactId = "android-common"
-                version = "2.0.3"
+                version = "2.0.4"
             }
         }
     }

sit-common/src/main/java/com/sit/common/base/BaseViewModel.kt

@@ -46,14 +46,12 @@ abstract class BaseViewModel : ViewModel() {
         MutableLiveData<Boolean>().apply { this.postValue(false) }
     val isSessionTimeOut: SingleLiveEvent<Boolean> = SingleLiveEvent()
     var isDataEmpty = false
-    val perPage = 25
+    var perPage = 25
     var page = 1
     var searchValue: String? = null
     var searchJob: Job? = null
     var isApiCalling = false
 
-    abstract fun updatePerPage()
-
     protected fun Response<out ResponseModel<out Any>>.checkResponse(): Boolean {
         return if (isSuccessful && body() != null) {
             true