Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code overall looks good. Great work! I've added comments in the code and have done a few changes.
Argument()
class which takes your command line arguments and uses either the default argument (in case the argument isn't passed) or the command line argument (if passed). It comes handy for most of the DL projects, since you experiment with different hyper-params./ $
in visual mode. I have removed any extra whitespaces or tabs, you can take a look at them in the changes.Environment.cpp
andA2CAgent.cpp
are inherited (I maybe wrong), and I hope they perform fine to your expectations.You can surely ignore these suggestions/comments as you should do what you feel is the best :)
cc: @vittorione94