fix(parser): Don't read the body of a DELETE message #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generally DELETE messages are treated like GET messages with different connotations, so this prevents client library headers from interfering with matching. Ideally, we'd be able to continue matching even if a single matcher has an error.
|
Kudos, SonarCloud Quality Gate passed!
|
|
@DolceTriade hey thanks for your contribution. |
|
Yes, the issue was that DELETE tried to read the body of a request that had no body and crashed (or prevented it from matching the request). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally DELETE messages are treated like GET messages with different connotations, so this prevents client library flags from interfering with matching.
Summary
Generally DELETE messages are treated like GET messages with different connotations, so this prevents client library flags from interfering with matching.
Checklist
Please check if your PR fulfills the following requirements:
Type
Does this PR introduce a breaking change?
Does this PR add new third-party libraries? If yes, please explain why