Append server type to lazy column index to make it unique #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this won't work. I am taking a look right now |
|
It resolved the issue but maybe there is a better more complete fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1186
Currently the app allows entering same media server as nip96 and blossom.
The server name is used as key for LazyColumn and this breaks LazyColumn as it doesn't allow duplicate key.
This fix prepends server type before serve name when used as key which makes it unique. This will prevent crash for any users that have already entered duplicate media servers.
Going forward do we want allow same media server as both nip96 and blossom or should we prevent it?
If we allow a media server as both nip96 and blossom should we make that clear on upload (not part of this pull request):
