Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added general tags that should be attached to all metrics #3

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

matlockx
Copy link

No description provided.

Copy link
Member

@markchadwick markchadwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! I will find some time to review this. Changing a 3rd party dependency may complicate things on our end, but I'll take a look to see.

.gitignore Outdated
@@ -0,0 +1,77 @@
# Created by .ignore support plugin (hsz.mobi)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to remove this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you meant the line? done

@matlockx
Copy link
Author

well in general i'm not sure about this pr because we forgot about it and so it grew over time. that's why you also see esailors in it. i guess we can also close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants